Ticket #29 (closed enhancement: fixed)

Opened 2 years ago

Last modified 9 months ago

constant-naming should be consistent

Reported by: Stadler Assigned to: somebody
Priority: minor Milestone: 0.9.5
Component: eAccelerator Version: 0.9.5
Keywords: constant consistent naming Cc:

Description

eAccelerator defines the following constants in PHP:

  • EACCELERATOR_VERSION
  • EACCELERATOR_SHM_AND_DISK
  • EACCELERATOR_SHM
  • EACCELERATOR_SHM_ONLY
  • EACCELERATOR_DISK_ONLY
  • EACCELERATOR_NONE
  • EA_LOG
  • EA_DEBUG
  • EA_PROFILE_OPCODES
  • EA_TEST_PERFORMANCE
  • EA_LOG_HASHKEYS

As you can see, some of the names begin with EACCELERATOR_ and some begin with EA_. In my opinion this is somewhat inconsistent, so I suggest to change the names so that all of them either begin with EA_ or with EACCELERATOR_ unless there is a good reason to name them differently.

Change History

03/28/06 11:10:02 changed by bart

  • status changed from new to closed.
  • version set to 0.9.5.
  • resolution set to fixed.
  • milestone changed from 1.0 to 0.9.5.

I've removed the EA_* constants because they couldn't be used in the php.ini files so they werent' very usefull.

08/24/07 13:55:57 changed by swart

  • keywords set to constant consistent naming.

Gay Kontakte

Porno Kontakte

Amateur Sex Kontakte

Amateur Swingers Guide