Optimizer drops catch blocks after break or continue in a loop

[feldgendler]

Code to reproduce

<?php
try {
    $i = 0;
    while($i++ < 3) {
        try {
            throw new Exception();
            break;
        } catch (Exception $e) {
            exit("PASSED\n");
        }
    }
} catch (Exception $e) {
        exit("FAILED\n");
}
?>

Expected result

PASSED

Actual result

FAILED

Additional info

The bug occurs only if the optimizer is enabled.

[feldgendler]

The reason is that the optimizer replaces opcodes ZEND_BRK and ZEND_CONT with ZEND_JMP at some stage. At one of the later stages, the optimizer sets a control flow path from ZEND_BRK, ZEND_CONT, ZEND_RETURN, and ZEND_EXIT to follow on to the innermost catch block -- this was intended as a measure against needlessly optimizing away catch blocks which follow these opcodes. However, because ZEND_BRK and ZEND_CONT get turned into ZEND_JMP before, this measure fails, and the catch block is dropped.

[feldgendler]

Patch to fix the bug

[feldgendler]

Please apply the attached patch.

My fix marks ZEND_BRK and ZEND_CONT instructions with extended_value when replacing them with ZEND_JMP. At the following stage, this mark is used to detect a former ZEND_BRK and ZEND_CONT and applying the necessary logic to them.

Sorry for the weird name of the attached file -- this was unintentional.

[hans]

I have just applied your patch to the repository. Thanks very much for your input!

[getagoodbuy]

I'm closing it according to the last comment. nike shoes wholesale

[4insure]

 Auto Insurance Quotes

[sim]

 decoration Changed 1 year ago by admin

 bathtub Changed 1 year ago by admin

 solar system Changed 1 year ago by admin

 stair parts Changed 1 year ago by admin

 solar supply Changed 1 year ago by admin