Ticket #159 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Revision [262] - typo in eaccelerator_list_keys?

Reported by: unknownbrackets Assigned to: somebody
Priority: minor Milestone:
Component: eAccelerator Version:
Keywords: Cc:

Description

Please forgive me if I'm wrong, but I happened to look at the changes for [262] (and [261]) and noticed the following:

if (eaccelerator_mm_instance == NULL && eaccelerator_list_keys(return_value TSRMLS_CC)) {
        return;
} else {
RETURN_NULL ();
}

Shouldn't that be...

if (eaccelerator_mm_instance != NULL && eaccelerator_list_keys(return_value TSRMLS_CC)) {
        return;
} else {
        RETURN_NULL ();
}

From my reading of the code, the current state means eaccelerator_list_keys() will most likely not work, and if eaccelerator_mm_instance is null, bad mojo could happen?

-[Unknown]

Change History

08/06/06 22:45:16 changed by bart

  • status changed from new to closed.
  • resolution set to fixed.

Thanks for catching this one!