Changeset 205

Timestamp:

05/04/06 15:00:20 (2 years ago)

Author:

bart

Message:

Don't store the doc_comments in op_array and class_entry. They are
useless. this should reduce memory footprint.

Files:

• eaccelerator/trunk/ChangeLog (modified) (1 diff)
• eaccelerator/trunk/ea_restore.c (modified) (6 diffs)
• eaccelerator/trunk/ea_store.c (modified) (6 diffs)
• eaccelerator/trunk/eaccelerator.h (modified) (2 diffs)

eaccelerator/trunk/ChangeLog

@@ +1 @@
+2006-05-04  Bart Vanbrabant <bart.vanbrabant at zoeloelip.be>
+
+        * Don't store the doc_comments in op_array and class_entry. They are 
+          useless. this should reduce memory footprint.
+
-2006-04-13  Bart Vanbrabant <bart.vanbrabant at zoeloelip.be>
-

eaccelerator/trunk/ea_restore.c

@@ -256 +256 @@
-#endif
-        FIXUP(from->filename);
-#ifdef ZEND_ENGINE_2
-        FIXUP(from->doc_comment);
-#endif
-}
-
@@ -267 +264 @@
-#ifdef ZEND_ENGINE_2
-        FIXUP(from->filename);
-        FIXUP(from->doc_comment);
-        fixup_zval_hash(&from->constants_table);
-        fixup_zval_hash(&from->default_properties);
@@ -648 +644 @@
-        to->line_start = from->line_start;
-        to->line_end = from->line_end;
-
-
-
-
-
-
-
-
+
+
-#else
-        to->uses_globals = from->uses_globals;
@@ -709 +699 @@
-        memcpy(to->name, from->name, from->name_length + 1);
-#ifdef ZEND_ENGINE_2_1
-
-
-
-
+
+
-#endif
-        return to;
@@ -857 +845 @@
-        to->line_start = from->line_start;
-        to->line_end = from->line_end;
-
+
+
-/*      if (from->filename != NULL) {
-                size_t len = strlen(from->filename) + 1;
@@ -864 +853 @@
-        }*/
-        to->filename = from->filename;
-        if (from->doc_comment != NULL) {
-                to->doc_comment = emalloc(from->doc_comment_len + 1);
-                memcpy(to->doc_comment, from->doc_comment, from->doc_comment_len + 1);
-        }
-
-        /* restore constants table */

eaccelerator/trunk/ea_store.c

@@ -79 +79 @@
-        EAG(mem) += sizeof(zend_property_info);
-        calc_string(from->name, from->name_length + 1 TSRMLS_CC);
-#ifdef ZEND_ENGINE_2_1
-        if (from->doc_comment != NULL) {
-                calc_string(from->doc_comment, from->doc_comment_len + 1 TSRMLS_CC);
-        }
-#endif
-}
-
@@ -263 +258 @@
-        if (from->filename != NULL)
-                calc_string(from->filename, strlen(from->filename) + 1 TSRMLS_CC);
-#ifdef ZEND_ENGINE_2
-        if (from->doc_comment != NULL)
-                calc_string(from->doc_comment, from->doc_comment_len + 1 TSRMLS_CC);
-#endif
-}
-
@@ -286 +277 @@
-        if (from->filename != NULL)
-                calc_string(from->filename, strlen(from->filename) + 1 TSRMLS_CC);
-
-
-
-
+
+
-        calc_zval_hash(&from->default_properties);
-
@@ -729 +718 @@
-        to->line_start = from->line_start;
-        to->line_end = from->line_end;
-        to->doc_comment_len = from->doc_comment_len;
-        if (from->doc_comment != NULL)
-                to->doc_comment = store_string(from->doc_comment, from->doc_comment_len + 1 TSRMLS_CC);
-#endif
-        return to;
@@ -746 +732 @@
-        to->name = store_string(from->name, from->name_length + 1 TSRMLS_CC);
-#ifdef ZEND_ENGINE_2_1
-
-
-
-
+
+
-#endif
-        return to;
@@ -893 +877 @@
-        to->line_start = from->line_start;
-        to->line_end = from->line_end;
-        to->doc_comment_len = from->doc_comment_len;
-
-        if (from->filename != NULL)
-                to->filename = store_string(from->filename, strlen(from->filename) + 1 TSRMLS_CC);
-        if (from->doc_comment != NULL)
-                to->doc_comment = store_string(from->doc_comment, from->doc_comment_len + 1 TSRMLS_CC);
-
-        store_zval_hash(&to->constants_table, &from->constants_table);

eaccelerator/trunk/eaccelerator.h

@@ -217 +217 @@
-        zend_uint line_start;
-        zend_uint line_end;
-        char *doc_comment;
-        zend_uint doc_comment_len;
-#endif
-} eaccelerator_op_array;
@@ -243 +241 @@
-        zend_uint line_start;
-        zend_uint line_end;
-        char *doc_comment;
-        zend_uint doc_comment_len;
-#endif
-} eaccelerator_class_entry;